Erase file pointer types for default log handler on Android #375
+62
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Oct 8, 2025
| // These C functions will be called from Swift. They provide a stable | ||
| // interface, hiding the pointer type differences between Android versions. | ||
|
|
||
| void *shim_stdout(void); |
There was a problem hiding this comment.
ideally, given them a little more unique prefixes. Maybe swift_log_android or smth. The alternative is to make them static inline functions and define them in the .h file which means they'll be inlined entirely and won't get a symbol at all.
There was a problem hiding this comment.
that way we can keep the .c file empty and we're not paying overhead. Example: https://github.com/apple/swift-nio/blob/dee7095f8d8a37a4cd165109768552163aa76458/Sources/CNIOLLHTTP/include/CNIOLLHTTP.h#L22-L26
There was a problem hiding this comment.
Also, we can do this for all platforms, no need to special-case Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a C shim to erase the pointer type of stdio types, that are different across Android versions.
With this addition
swift-logand any packages that use it can be compiled on Android 23+Resolves #374